Update codex to 0.121.0 - #95
Closed
codex-acp-ci-app[bot] wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously failed tests and reasons:
src/__tests__/CodexACPAgent/mcp-session.test.ts(should return configured mcp) failed withFailed to initialize session: Read-only file system (os error 30)because Codex/MCP startup tried to use non-writable default state paths.CODEX_HOMEwas set but missing (CODEX_HOME points to ... but that path does not exist), and an intermittent teardown failure (ENOTEMPTY) during temp directory removal.What I changed and why:
src/CodexEventHandler.tsfromthread/realtime/transcriptUpdatedto explicitthread/realtime/transcript/deltaandthread/realtime/transcript/doneno-op cases to match regenerated app-server types after the update and restore switch exhaustiveness/type safety.src/__tests__/CodexACPAgent/mcp-session.test.tsto run Codex with a per-test writableHOME/CODEX_HOME, createCODEX_HOMEbefore startup, use an explicit resolvedcwd, restore env vars after test, and make cleanup best-effort to avoid transient filesystem race failures.